-
-
Notifications
You must be signed in to change notification settings - Fork 40
v6.6.54 #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.6.54 #67
Conversation
Summary of ChangesHello @luispater, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on two main areas: updating external sponsor information and introducing a new performance optimization feature. The sponsor details in the documentation have been refreshed to highlight the GLM-4.7 model. Additionally, a 'commercial-mode' has been added, allowing the system to reduce resource consumption by selectively disabling certain HTTP middleware, like request logging, which can be crucial for maintaining efficiency under heavy load. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a commercial-mode configuration option to disable high-overhead HTTP middleware, specifically request logging, for improved performance in high-concurrency environments. The changes include adding the new flag to the configuration files and struct, and updating the server initialization logic to conditionally add the middleware.
My review focuses on the implementation and documentation of this new feature. The logic is sound, but I've suggested improvements to the comments in config.example.yaml and internal/config/config.go to clarify that the commercial-mode setting is only applied at server startup and is not hot-reloadable. This will help prevent user confusion.
| # Enable debug logging | ||
| debug: false | ||
|
|
||
| # When true, disable high-overhead HTTP middleware features to reduce per-request memory usage under high concurrency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new commercial-mode setting is a great addition for performance-sensitive deployments. However, it's important to note that this setting is only applied when the server starts. Changes to this value in the configuration file will not be applied dynamically during runtime via hot-reloading. It would be beneficial to clarify this in the comment to avoid confusion for users who might expect it to be hot-reloadable like other settings.
I suggest updating the comment to reflect this.
# When true, disable high-overhead HTTP middleware features to reduce per-request memory usage under high concurrency. This setting only takes effect on server startup.| // Debug enables or disables debug-level logging and other debug features. | ||
| Debug bool `yaml:"debug" json:"debug"` | ||
|
|
||
| // CommercialMode disables high-overhead HTTP middleware features to minimize per-request memory usage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to my comment on config.example.yaml, it's worth clarifying in the code documentation that CommercialMode is a startup-only configuration. This will help future developers understand its behavior without having to trace its usage.
| // CommercialMode disables high-overhead HTTP middleware features to minimize per-request memory usage. | |
| // CommercialMode disables high-overhead HTTP middleware features to minimize per-request memory usage. This setting only takes effect on server startup. |
No description provided.