Skip to content

Conversation

@luispater
Copy link

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @luispater, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on two main areas: updating external sponsor information and introducing a new performance optimization feature. The sponsor details in the documentation have been refreshed to highlight the GLM-4.7 model. Additionally, a 'commercial-mode' has been added, allowing the system to reduce resource consumption by selectively disabling certain HTTP middleware, like request logging, which can be crucial for maintaining efficiency under heavy load.

Highlights

  • Sponsor Information Update: The README files (English and Chinese versions) have been updated to reflect the sponsor's latest GLM-4.7 model, including changes to the image links and descriptive text.
  • New Commercial Mode Configuration: A new configuration option, commercial-mode, has been introduced. When enabled, this mode is designed to disable high-overhead HTTP middleware features, such as request logging, to reduce per-request memory usage, particularly beneficial in high-concurrency environments.
  • Conditional Request Logging: The application's server logic has been modified to conditionally enable or disable the request logging middleware based on the commercial-mode setting in the configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@luispater luispater merged commit cf8b2dc into router-for-me:main Dec 25, 2025
2 checks passed
@luispater luispater deleted the plus branch December 25, 2025 13:07
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a commercial-mode configuration option to disable high-overhead HTTP middleware, specifically request logging, for improved performance in high-concurrency environments. The changes include adding the new flag to the configuration files and struct, and updating the server initialization logic to conditionally add the middleware.

My review focuses on the implementation and documentation of this new feature. The logic is sound, but I've suggested improvements to the comments in config.example.yaml and internal/config/config.go to clarify that the commercial-mode setting is only applied at server startup and is not hot-reloadable. This will help prevent user confusion.

# Enable debug logging
debug: false

# When true, disable high-overhead HTTP middleware features to reduce per-request memory usage under high concurrency.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new commercial-mode setting is a great addition for performance-sensitive deployments. However, it's important to note that this setting is only applied when the server starts. Changes to this value in the configuration file will not be applied dynamically during runtime via hot-reloading. It would be beneficial to clarify this in the comment to avoid confusion for users who might expect it to be hot-reloadable like other settings.

I suggest updating the comment to reflect this.

# When true, disable high-overhead HTTP middleware features to reduce per-request memory usage under high concurrency. This setting only takes effect on server startup.

// Debug enables or disables debug-level logging and other debug features.
Debug bool `yaml:"debug" json:"debug"`

// CommercialMode disables high-overhead HTTP middleware features to minimize per-request memory usage.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to my comment on config.example.yaml, it's worth clarifying in the code documentation that CommercialMode is a startup-only configuration. This will help future developers understand its behavior without having to trace its usage.

Suggested change
// CommercialMode disables high-overhead HTTP middleware features to minimize per-request memory usage.
// CommercialMode disables high-overhead HTTP middleware features to minimize per-request memory usage. This setting only takes effect on server startup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant