-
-
Notifications
You must be signed in to change notification settings - Fork 40
v6.6.56 #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.6.56 #68
Conversation
… enhance deduplication logic
docs: add Quotio to community projects
Summary of ChangesHello @luispater, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily enhances the system's ability to manage and track usage data by introducing export and import capabilities for request statistics. It also refines the authentication indexing mechanism to provide a more stable and consistent identifier for authentication records. Additionally, the project's documentation has been updated to include a new integration. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable feature for exporting and importing usage statistics, which is great for backup and migration purposes. The implementation of the new API endpoints and the logic for merging statistics snapshots seems solid. Additionally, the refactoring of AuthIndex from a numeric ID to a stable, hash-based string is a significant improvement for consistency and reliability across restarts. I've found one area with minor code duplication that could be refactored for better maintainability. Overall, these are great changes.
| func normaliseTokenStats(tokens TokenStats) TokenStats { | ||
| if tokens.TotalTokens == 0 { | ||
| tokens.TotalTokens = tokens.InputTokens + tokens.OutputTokens + tokens.ReasoningTokens | ||
| } | ||
| if tokens.TotalTokens == 0 { | ||
| tokens.TotalTokens = tokens.InputTokens + tokens.OutputTokens + tokens.ReasoningTokens + tokens.CachedTokens | ||
| } | ||
| return tokens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic in this new normaliseTokenStats function is identical to the logic within the existing normaliseDetail function (lines 447-452). This introduces code duplication. To improve maintainability, you could refactor normaliseDetail to use this new normaliseTokenStats function, which would centralize the token normalization logic.
No description provided.