-
-
Notifications
You must be signed in to change notification settings - Fork 55
v6.6.81 #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.6.81 #80
Conversation
添加 CodMate 应用的描述,提供 CLI AI 会话管理功能。
Added CodMate section to README with app details.
docs: add CodMate to community projects
Moved CodMate entry under ProxyPal in both English and Chinese README files for consistency in structure and better readability.
…g during refresh Introduced `tokenRefreshTimeout` constant for token refresh operations and enhanced context propagation for `refreshToken` by embedding roundtrip information if available. Adjusted `refreshAuth` to ensure default context initialization and handle cancellation errors appropriately.
…as handling Implemented `Fork` flag in `ModelNameMapping` to allow aliases as additional models while preserving the original model ID. Updated the `applyOAuthModelMappings` logic, added tests for `Fork` behavior, and updated documentation and examples accordingly.
…o-OpenAI conversion Fixed incorrect boundary logic for `message_delta` emission, ensuring proper handling of usage updates and `emitMessageStopIfNeeded` within the response loop.
Summary of ChangesHello @luispater, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily enhances the model mapping capabilities by introducing a 'fork' option, allowing model aliases to function as separate, discoverable models. It also refines the Antigravity token refresh process for better reliability and corrects a minor sequencing issue in Claude's streaming responses. Additionally, the project documentation has been updated to feature a new integration. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new fork option for OAuth model mappings, which allows a model to be available under both its original name and an alias. This is a useful feature enhancement. The changes also include several important improvements, such as adding a timeout and better context handling for token refresh operations to improve robustness, and fixing a bug in the OpenAI-to-Claude response translator. I appreciate the addition of new tests that cover the new fork functionality, ensuring its correctness.
I have one suggestion to refactor a small piece of duplicated code for better maintainability. Overall, this is a solid pull request.
I am having trouble creating individual review comments. Click here to see my feedback.
sdk/cliproxy/service.go (1271-1287)
The logic to handle cases where a model has no mapping (!ok) or the mapping has an empty alias (mappedID == "") is duplicated. You can combine these two conditions to simplify the code, reduce duplication, and improve readability.
if !ok || strings.TrimSpace(entry.alias) == "" {
if _, exists := seen[key]; !exists {
seen[key] = struct{}{}
out = append(out, model)
}
continue
}
mappedID := strings.TrimSpace(entry.alias)
No description provided.