-
-
Notifications
You must be signed in to change notification settings - Fork 69
feat(kiro): add OAuth model name mappings support for Kiro #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kiro): add OAuth model name mappings support for Kiro #82
Conversation
Summary of ChangesHello @FakerL, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for 'Kiro' within the OAuth model name mapping system. The primary goal is to allow Kiro-specific model identifiers, particularly those associated with AWS CodeWhisperer/Copilot, to be consistently mapped to standardized canonical names. This enhancement ensures that models from the Kiro channel are correctly recognized and routed, improving the overall consistency and functionality of model management within the CLIProxyAPIPlus framework. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds support for kiro to the OAuth model name mappings feature. The changes in config.example.yaml provide a clear example for users, and the modification in sdk/cliproxy/auth/model_name_mappings.go properly integrates kiro as a supported channel. The implementation is clean, straightforward, and aligns with the stated goal of keeping the kiro provider logic isolated for easier future merges. The changes look good and I have no suggestions for improvement.
Add Kiro to the list of supported channels for OAuth model name mappings, allowing users to map Kiro model IDs (e.g., kiro-claude-opus-4-5) to canonical model names (e.g., claude-opus-4-5-20251101). The Kiro case is implemented as a separate switch block to keep it isolated from upstream CLIProxyAPI providers, making future merges from the upstream repository cleaner. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
8f9edef to
08e8fdd
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for kiro to the OAuth model name mappings. The changes include updating the example configuration file to list kiro as a supported channel and adding a case for it in the OAuthModelMappingChannel function. The implementation is straightforward. I've provided one suggestion to refactor the switch statement to reduce code duplication and improve maintainability. Additionally, consider adding a unit test for the OAuthModelMappingChannel function to verify the new kiro case and prevent regressions.
kiro-claude-opus-4-5) to canonical model names (e.g.,claude-opus-4-5-20251101)Details
Previously,
oauth-model-mappingsconfiguration only supported upstream CLIProxyAPI providers (gemini-cli, vertex, aistudio, antigravity, claude, codex, qwen, iflow). Kiro (a CLIProxyAPIPlus-only feature for AWS CodeWhisperer/Copilot support) was not included.This change adds a separate case block for
kiroin theOAuthModelMappingChannelfunction. The case is kept isolated from the upstream providers to make future merges/syncs from CLIProxyAPI cleaner.