Fix slice assignment and ensure int() cast is done#119
Open
lbt wants to merge 2 commits intorpi-ws281x:masterfrom
Open
Fix slice assignment and ensure int() cast is done#119lbt wants to merge 2 commits intorpi-ws281x:masterfrom
lbt wants to merge 2 commits intorpi-ws281x:masterfrom
Conversation
The caller can't cast this when value is a slice This matters when a Numpy array is being used. Signed-off-by: David Greaves <david@dgreaves.com>
This functionality was lost in commit: f80276b Signed-off-by: David Greaves <david@dgreaves.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use the slice assignment which was removed (probably by accident) in f80276b.
This restores it.
There is also an issue in sending slices from a numpy array as even a numpy.uint32 is not accepted:
TypeError: in method 'ws2811_led_set', argument 3 of type 'uint32_t'
This could fix #115