Fix removal of feats_lost from feats_marg and noisy sim feats out of camera frames#512
Open
lewisjiang wants to merge 2 commits intorpng:masterfrom
Open
Fix removal of feats_lost from feats_marg and noisy sim feats out of camera frames#512lewisjiang wants to merge 2 commits intorpng:masterfrom
feats_lost from feats_marg and noisy sim feats out of camera frames#512lewisjiang wants to merge 2 commits intorpng:masterfrom
Conversation
Author
|
Another bug about simulation features going out of camera frame bounds after adding noise is fixed. See here |
lewisjiang
changed the title
feats_lost from feats_margfeats_lost from feats_marg and noisy sim feats out of camera frames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the comment above and the context of the code, it seems that we select
feats_maxtracksfromfeats_marg, and we do not want to promote newly lost features to maxtracks features. However, there are features held both byfeats_margandfeats_lost. Therefore we need to remove the overlaps fromfeats_margcontainer instead offeats_lost.