build(tests): migrate to MSTest v4 #796
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date test SDK - Update dev test deps: - Microsoft.NET.Test.Sdk: 17.14.1 → 18.0.0 - MSTest.TestAdapter: 3.9.3 → 4.0.1 - MSTest.TestFramework: 3.9.3 → 4.0.1 - Replace Assert.ThrowsException<T> → Assert.ThrowsExactly<T> where exact type is required - Remove unused `using Microsoft.SqlServer.Management.HadrModel;` Rationale: MSTest v4 removes deprecated *ThrowsException* APIs; tests updated in lockstep with package upgrades to keep the build passing.
There was a problem hiding this comment.
Pull Request Overview
Migrates test project to MSTest v4 and updates assertions to use the new Assert.ThrowsExactly API.
- Upgrade Microsoft.NET.Test.Sdk and MSTest packages to specified newer versions.
- Replace Assert.ThrowsException with Assert.ThrowsExactly in tests where exact exception type matching is desired.
- No functional production code changes; only test infrastructure and assertion semantics updated.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/DacpacTool.Tests/ScriptParserTests.cs | Updated assertion to Assert.ThrowsExactly for precise exception type matching. |
| test/DacpacTool.Tests/PackageBuilderTests.cs | Switched to Assert.ThrowsExactly to enforce non-polymorphic exception expectation. |
| test/DacpacTool.Tests/DacpacTool.Tests.csproj | Bumped test SDK and MSTest framework/adapter package versions to v4-compatible releases. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ErikEJ
approved these changes
Oct 18, 2025
|
@nmummau We have a flaky test, could you change stopWatch.ElapsedMilliseconds.ShouldBeLessThan(20); to stopWatch.ElapsedMilliseconds.ShouldBeLessThan(30); In VersionChekertest ? |
The test `RunsVersionCheck` previously asserted that the cached version check must complete in under 20 ms. This tight bound caused intermittent failures in slower environments (e.g. CI). Increase the threshold to 30 ms to make the test more robust while still verifying the caching behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and adopt Assert.ThrowsExactly; update test SDK
using Microsoft.SqlServer.Management.HadrModel;Rationale: MSTest v4 removes deprecated ThrowsException APIs; tests updated in lockstep with package upgrades to keep the build passing.
Also fixed a failing test.