build(tests): enable nullable refs and bump LangVersion to C# 12 #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is the difference so huge? |
There was a problem hiding this comment.
Pull Request Overview
Modernizes the test project by enabling nullable reference types and updating the C# language version, alongside refactoring namespaces to file-scoped form.
- Set LangVersion to 12 and enabled nullable reference types.
- Converted all namespace declarations to file-scoped.
- Adjusted a helper method parameter to be explicitly nullable and changed certain assertion APIs (introducing a potential issue).
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| VersionCheckerTests.cs | Converted to file-scoped namespace. |
| TestVersionProvider.cs | Converted to file-scoped namespace. |
| TestModelBuilder.cs | File-scoped namespace; made fileName parameter nullable. |
| TestConsole.cs | File-scoped namespace refactor. |
| ScriptParserTests.cs | File-scoped namespace; changed assertion API (potential misuse). |
| ScriptInspectorTests.cs | File-scoped namespace. |
| PropertyParserTest.cs | File-scoped namespace. |
| PackageDeployerTests.cs | File-scoped namespace. |
| PackageBuilderTests.cs | File-scoped namespace; changed assertion API (potential misuse). |
| PackageAnalyzerTests.cs | File-scoped namespace. |
| ExtensionsTest.cs | File-scoped namespace. |
| DacpacTool.Tests.csproj | Enabled nullable references and bumped LangVersion to 12. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ErikEJ
requested changes
Oct 18, 2025
nmummau
force-pushed
the
chore/tests-langv
branch
from
4d5b3ab to
b2701b9
Compare
…est project - Set <LangVersion> to 12 (was 9.0) - Enable nullable reference types: <Nullable>enable</Nullable>
nmummau
force-pushed
the
chore/tests-langv
branch
from
b2701b9 to
82d01d0
Compare
I've removed the file scoped namespace changes from this PR |
|
@nmummau Now that this is done, you should address the 300 build warnings 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable nullable refs and bump LangVersion to C# 12 in test project
Aims to modernize the test project to current C# features and improve null-safety.