Skip to content

Conversation

jakewski
Copy link

re-implementing a critical fix from #1610 to have a fresh CI result and bump priority (thank you @ababik !)

linked issue: #1609

@Copilot Copilot AI review requested due to automatic review settings September 26, 2025 18:09
Copy link

changeset-bot bot commented Sep 26, 2025

⚠️ No Changeset found

Latest commit: 7ce7796

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where hidden input fields were not properly masked when the maskAllInputs option is enabled in rrweb. The fix ensures that hidden inputs are included in the default masking behavior for security purposes.

Key changes:

  • Added hidden: true to the default mask input options when maskAllInputs is enabled
  • Updated the MaskInputOptions type to include a hidden field
  • Added test coverage with a hidden input field in the test HTML

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/rrweb/src/record/index.ts Adds hidden: true to default mask options when maskAllInputs is enabled
packages/rrweb-snapshot/src/types.ts Extends MaskInputOptions type to include hidden boolean field
packages/rrweb-snapshot/src/snapshot.ts Adds hidden: true to default mask options in snapshot function
packages/rrweb/test/html/form.html Adds hidden input field to test form for validation
packages/rrweb/test/snapshots/integration.test.ts.snap Updates test snapshots to reflect hidden input masking behavior
packages/rrweb/test/record/snapshots/cross-origin-iframes.test.ts.snap Updates cross-origin iframe test snapshots

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant