Skip to content

fix: prevent mem leaks by removing unloaded iframes from map #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

fix: prevent mem leaks by removing unloaded iframes from map #1747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shy-carrots-deny.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"rrweb": patch
---

fix potential mem leaks by deleting unloaded iframes from crossOriginIframeMap
6 changes: 5 additions & 1 deletion packages/rrweb/src/record/iframe-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,16 @@
});

// Receive messages (events) coming from cross-origin iframes that are nested in this same-origin iframe.
if (this.recordCrossOriginIframes)
if (this.recordCrossOriginIframes) {
iframeEl.contentWindow?.addEventListener(
'message',
this.handleMessage.bind(this),
);

iframeEl.contentWindow?.addEventListener('pagehide', () => {
this.crossOriginIframeMap.delete(iframeEl.contentWindow!);

Check warning on line 87 in packages/rrweb/src/record/iframe-manager.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/rrweb/src/record/iframe-manager.ts#L87 

[@typescript-eslint/no-non-null-assertion] Forbidden non-null assertion.
});
}
this.loadListener?.(iframeEl);

if (
Expand Down
Loading