fix(snapshot): use link.sheet for CSS capture on WebKit#1825
Open
d0ugal wants to merge 2 commits into
Open
Conversation
On WebKit at readyState "interactive", external stylesheets are not yet listed in document.styleSheets, but HTMLLinkElement.sheet is already populated. Fall back to link.sheet before searching document.styleSheets so that inlineStylesheet captures CSS correctly on Safari/WebKit.
🦋 Changeset detectedLatest commit: 5c3e5f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
That's super and yes I think I've made a similar change in the StyleSheet Assets branch which will become rrweb 2.1: I think you might not need the fallback to searching the array? |
Fix inline stylesheet capture on WebKit by reading CSS rules from `HTMLLinkElement.sheet` before falling back to `document.styleSheets`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
inlineStylesheetis enabled, rrweb searchesdocument.styleSheetsto find theCSSStyleSheetfor each<link>element and inline its rules as_cssText.On WebKit (Safari), at
readyState: "interactive", external stylesheets loaded via<link>are not yet listed indocument.styleSheets— only inline<style>elements appear. This means full snapshots taken at page load capture_cssText: ""for all external stylesheets, producing unstyled replays.However,
HTMLLinkElement.sheetis already populated at this point on WebKit.Fix
Check
link.sheetbefore falling back todocument.styleSheets.find():Testing
Verified with Angular apps across Chrome, Firefox, and Safari (Playwright WebKit)