-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tox, Pipenv, Docker (-compose) and a sketch of a client cli #35
base: main
Are you sure you want to change the base?
Conversation
Does the client stuff look good-ish? Should I keep going with that? @rsalmei |
Hello @jrabbit, how are you? Anyway, I'll take a more in depth look in your PR, but I do like the client stuff! Would you mind merging into another branch of mine, and I made the tweaks in there? |
Hey guys, I also tried to make this tool work in a container with no luck. I didn't notice this PR and will give it a try! My main issue is with gRPC, which I don't know well. I just can't make the client connect to the server inside the container. All I get is connection refused... I have been pulling my hair for an entire day now. |
Hey @nvictor ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrabbit: Congratulates for your initiative :)
I added some commentaries in the PR, could you please take a look at it?
LABEL maintainer "Jack Laxson <[email protected]>" | ||
|
||
RUN mkdir -p /usr/src/clearly /usr/share/cache/ && \ | ||
chmod 777 /usr/share/cache/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 777
- We should run the
clearly
as a non-privileged user.
@rsalmei: I loved the @jrabbit initiative, I found it before proposing something similar. I would like to have a clearly official container to use in my infrastructure. In addition to the @jrabbit example, I think that we should consider:
|
6e5f9d0
to
d7f847f
Compare
c8770b7
to
8984a89
Compare
Hey hows it going; I moved a bunch of stuff into a new workflow let me know how you feel about it!
The client isn't done yet but I'd like some feedback first. I need to add the dist/dev tools to the pipfile still (or you can as an exercise 😉)
I also had some issues with pytest sugar