Allow overriding system user on db create. #2261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks consistent with SYSTEM password. |
yahonda
reviewed
Feb 24, 2022
lib/active_record/connection_adapters/oracle_enhanced/database_tasks.rb
Outdated
Show resolved
Hide resolved
|
Please rebase from the master branch to address RSpec failures. |
yahonda
requested changes
Feb 26, 2022
| @@ -13,11 +13,14 @@ def initialize(config) | |||
| end | |||
|
|
|||
| def create | |||
| system_username = ENV["ORACLE_SYSTEM_USER"] || 'SYSTEM' | |||
There was a problem hiding this comment.
Use double quote "SYSTEM", not 'SYSTEM' to make RuboCop happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2257
Change to allow the a user to specify a different system user. I went with only allowing via an environment variable, as adding a new $stdin might quality as a breaking change.