-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
This pull request introduces 1 alert when merging 4231f32 into 90fbf8e - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all,
Overrides to perform operation with multiple values (get content from multiple keys for instance)
do we want to do this or use different method names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes we talked about:
- Activate
test:ci
script to enable Circle CI before merging - DID Auth token management is white box. That lead into two conclusions: analyse wether we need to test this or not, and remove access token related methods from client interface.
f9a16bb
to
e9bdb0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work!
|
||
- Stores the authentication credentials in the given storage | ||
|
||
## Usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move all this section directly to docs. It is very big for a readme.
## Usage | |
## Usage | |
[Read the docs](https://rsksmart.github.io/rif-identity-docs/data-vault/cpinner/cpinner-client) | |
I will then review and iterate docs over that PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the option. I now put request changes for stuff described above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic
Closes #3
Open work: