Skip to content
This repository was archived by the owner on May 19, 2023. It is now read-only.

Web DV Client SDK #11

Merged
merged 20 commits into from
Nov 20, 2020
Merged

Web DV Client SDK #11

merged 20 commits into from
Nov 20, 2020

Conversation

javiesses
Copy link
Contributor

@javiesses javiesses commented Nov 13, 2020

Closes #3

  • Deleted old version
  • Get content
  • Create content
  • Login process
  • Tests for every written method
  • Fixed typeorm version across the entire repo
  • README brief
  • Swap content
  • Delete content
  • Refresh access token when necessary
  • Login again when refresh token is expired
  • Refactor internal methods

Open work:

@javiesses javiesses requested a review from ilanolkies November 13, 2020 20:56
@lgtm-com
Copy link

lgtm-com bot commented Nov 13, 2020

This pull request introduces 1 alert when merging 4231f32 into 90fbf8e - view on LGTM.com

new alerts:

  • 1 for Ineffective parameter type

Copy link
Contributor

@ilanolkies ilanolkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all,

Overrides to perform operation with multiple values (get content from multiple keys for instance)

do we want to do this or use different method names?

Copy link
Contributor

@ilanolkies ilanolkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes we talked about:

  • Activate test:ci script to enable Circle CI before merging
  • DID Auth token management is white box. That lead into two conclusions: analyse wether we need to test this or not, and remove access token related methods from client interface.

@javiesses javiesses force-pushed the dv-client branch 2 times, most recently from f9a16bb to e9bdb0c Compare November 18, 2020 20:10
@javiesses javiesses marked this pull request as ready for review November 18, 2020 20:53
Copy link
Contributor

@ilanolkies ilanolkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work!


- Stores the authentication credentials in the given storage

## Usage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move all this section directly to docs. It is very big for a readme.

Suggested change
## Usage
## Usage
[Read the docs](https://rsksmart.github.io/rif-identity-docs/data-vault/cpinner/cpinner-client)

I will then review and iterate docs over that PR

Copy link
Contributor

@ilanolkies ilanolkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the option. I now put request changes for stuff described above.

Copy link
Contributor

@ilanolkies ilanolkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic

@ilanolkies ilanolkies merged commit 44777c3 into master Nov 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the dv-client branch November 20, 2020 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create DataVaultProvider Web Client SDK
2 participants