This repository was archived by the owner on May 19, 2023. It is now read-only.
Web DV Client SDK#11
Merged
Merged
Conversation
|
This pull request introduces 1 alert when merging 4231f32 into 90fbf8e - view on LGTM.com new alerts:
|
ilanolkies
reviewed
Nov 16, 2020
ilanolkies
suggested changes
Nov 16, 2020
ilanolkies
left a comment
ilanolkies
left a comment
Contributor
There was a problem hiding this comment.
Some minor changes we talked about:
- Activate
test:ciscript to enable Circle CI before merging - DID Auth token management is white box. That lead into two conclusions: analyse wether we need to test this or not, and remove access token related methods from client interface.
javiesses
force-pushed
the
dv-client
branch
2 times, most recently
from
November 18, 2020 20:10
f9a16bb to
e9bdb0c
Compare
javiesses
marked this pull request as ready for review
November 18, 2020 20:53
ilanolkies
approved these changes
Nov 19, 2020
|
|
||
| - Stores the authentication credentials in the given storage | ||
|
|
||
| ## Usage |
Contributor
There was a problem hiding this comment.
I would move all this section directly to docs. It is very big for a readme.
Suggested change
| ## Usage | |
| ## Usage | |
| [Read the docs](https://rsksmart.github.io/rif-identity-docs/data-vault/cpinner/cpinner-client) | |
I will then review and iterate docs over that PR
ilanolkies
suggested changes
Nov 19, 2020
ilanolkies
left a comment
ilanolkies
left a comment
Contributor
There was a problem hiding this comment.
I missed the option. I now put request changes for stuff described above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
Open work: