DAO-524 adding filter param for transactions #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleyter93
force-pushed
the
DAO-524
branch
3 times, most recently
from
bc4fd3c to
a3054dc
Compare
jessgusclark
requested changes
Jul 11, 2024
Member
jessgusclark
left a comment
jessgusclark
left a comment
There was a problem hiding this comment.
I didn't mark all the places for flow but see the first top comment and use it below. Then one code cleanup that looks to be from the previous code but was touched so we might as well fix it.
sleyter93
force-pushed
the
DAO-524
branch
2 times, most recently
from
8e5de74 to
adfb1fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://rsklabs.atlassian.net/browse/DAO-524,
I added a new filter for transactions. The param is called
flowThis param could be
to,from, orall(default value)The DAO instance is going to filter directly in Blockscout.
The Wallet instance is going to ignore this filter.