-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add compatibility for have_enqueued_mail (rails 7) #2537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've started incorporating your fix, but failed to do so. I hope you'll find this part useful to get specs to green. |
Thank you, that's super helpful. I'll see about running the tests locally. Will try to finish it up in a bit. |
1. ActionMailer::DeliveryJob does not exist anymore 2. ActionMailer::Parameterized::DeliveryJob According to my research they have both been superseeded by ActionMailer::MailDeliveryJob Closes rspec#2531
844a5bc
to
495d818
Compare
Seems the tests passed? You have a pretty complex setup but I remove the commit I used to test everything @pirj , let me know if anything else is needed. |
Please don't be deceived by the green status of https://github.com/rspec/rspec-rails/runs/4309351309?check_suite_focus=true
That's basically the same failure I choked on when integrated your fix. |
Oh man, you have a complex setup. I was indeed super happy that everything was (not passing) lol. Let me try and run the tests locally so that I can debug. |
Have you had a chance to check the failure, @mhenrixon ? |
Have you had a chance to check the failure, @mhenrixon ? I have tried and failed @pirj, I am moving my family in a few days and likely won't have time to sit down with this until after Christmas. |
No worries, take your time and have a great holiday. I might have a chance to try to tweak the PR earlier. |
Fixed in #2546. Thanks for your contribuion, @mhenrixon ! |
According to my research they have both been superseeded by ActionMailer::MailDeliveryJob
Closes #2531