Skip to content

Support chages to show_helper in Rails 7#2833

Open
rickselby wants to merge 1 commit intorspec:mainfrom
rickselby:show_helper_rails_7
Open

Support chages to show_helper in Rails 7#2833
rickselby wants to merge 1 commit intorspec:mainfrom
rickselby:show_helper_rails_7

Conversation

@rickselby
Copy link

This is a continuation of #2741

#2492 overrode show_helper, which in Rails 6 looks like:

def show_helper
  "#{singular_route_name}_url(@#{singular_table_name})"
end

But Rails 7 changed it to

def show_helper(arg = "@#{singular_table_name}", type: :url) # :doc:
  "#{singular_route_name}_#{type}(#{arg})"
end

This change supports the arguments in Rails 7 while maintaining support for Rails 6.

I've updated the edit_spec.rb template to use the show_helper helper rather than building the path itself, and have added a test to confirm the expected path is generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments