Skip to content

[IN PROGRESS] Update to pivot functions #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mine-cetinkaya-rundel wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[IN PROGRESS] Update to pivot functions #91

mine-cetinkaya-rundel wants to merge 4 commits into from

Conversation

@mine-cetinkaya-rundel
Copy link
Member

@mine-cetinkaya-rundel mine-cetinkaya-rundel commented Mar 2, 2020 •
edited
Loading

What I've already done:

  • spread/gather -> pivot_*
  • Fix a few typos
  • Add missing links to other primers
  • Update one slightly confusing MC question

What we need to make a decision on before PR can be merged:

  • There was one note in the existing primer "[To be replaced with a video]". I haven't taken that out. We can make the video or take out that note.
  • There are two existing videos (search for "vimeo" in the document) that will need to be updated. I imagine @garrettgman has the keynote slides that go with them. I'd be happy to update if you can share the Keynote slides, or we can hold off until you can make the videos and merge the PR then.

I'll leave the PR title "in progress" until we make a decision on these.

@mine-cetinkaya-rundel
Update to pivot functions
0fc14f9 
- spread/gather -> pivot_*
- Fix a few typos
- Add missing links to other primers
- Update one slightly confusing MC question
@mine-cetinkaya-rundel mine-cetinkaya-rundel requested review from apreshill and removed request for garrettgman March 2, 2020 15:25
apreshill
apreshill reviewed Mar 2, 2020
View reviewed changes
apreshill
apreshill reviewed Mar 2, 2020
View reviewed changes
Copy link

@apreshill apreshill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I left some editorial comments (feel free to use what is useful, ignore what it not), and I think I only noticed one typo :)

andrewheiss added a commit to andrewheiss/primers that referenced this pull request Jan 3, 2024
@andrewheiss
Update to use |> and pivot_*
11fd75a 
Mostly via rstudio-education#91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@apreshill apreshill apreshill left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mine-cetinkaya-rundel @apreshill