-
Notifications
You must be signed in to change notification settings - Fork 9
Chore: Migrate from radix-ui to base-ui #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abhishekxix
wants to merge
23
commits into
develop
Choose a base branch
from
chore/migrate-to-base-ui
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
db6ff8a
Migrate Dropdown from radix-ui to base-ui
abhishekxix 47577a7
Migrate Dialog from radix-ui to base-ui
abhishekxix 0fb4d38
Remove radix-ui dialog and dropdown menu
abhishekxix 9a0e925
Migrate Tooltip from radix-ui to base-ui
abhishekxix d8cf571
Remove radix-ui tooltip
abhishekxix 7fc2d6b
WIP: Migrate toast component from radix-ui to base-ui
abhishekxix f8393ec
Migrate Toast from radix-ui to base-ui
abhishekxix e30b1b7
Remove radix-ui toast
abhishekxix e472a45
Fix timeout logic
abhishekxix 40ec5d0
Add type keyword to type imports
abhishekxix d5b067b
Update toast styles for animation
abhishekxix 42bf300
Fix dropdown not showing inside dialog
abhishekxix 8fc9565
Convert conditional classes to clsx call
abhishekxix 4b987c1
Prevent layout shift on dropdown open
abhishekxix fa53325
Update packages/frappe-ui-react/src/components/dropdown/dropdown.tsx
abhishekxix 7ba1eb2
Replace string interpolation with clsx
abhishekxix 696587d
Revert the initial z-index for dropdown and dialog
abhishekxix dfe4f8a
Fix escaping issue in toast description
abhishekxix e3c8d0a
Fix async issues and add test cases for dropdown
abhishekxix 6d65f32
Add more test cases for dropdown component
abhishekxix 6eea34d
Add test cases for toast
abhishekxix e732ac7
Add test cases for tooltip
abhishekxix c2e64de
Remove unused import for act
abhishekxix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.