Feature: Add components #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up, and Separator stories to include dynamic source
…nd Skeleton components
ayushnirwal
reviewed
Jan 14, 2026
Collaborator
| "@popperjs/core": "^2.11.8", | ||
| "@radix-ui/react-dialog": "^1.1.14", | ||
| "@radix-ui/react-dropdown-menu": "^2.1.15", | ||
| "@radix-ui/react-label": "^2.1.8", |
Collaborator
There was a problem hiding this comment.
Radix UI is used. These should be derived from Base UI
| lg: "text-lg", | ||
| }; | ||
|
|
||
| const themeClasses: Record<RadioGroupTheme, string> = { |
Collaborator
| name, | ||
| orientation = "vertical", | ||
| }) => { | ||
| const sizeClasses: Record<RadioGroupSize, string> = { |
Collaborator
There was a problem hiding this comment.
Constants should not be declared in the components.
Collaborator
There was a problem hiding this comment.
There is no radio group in the docs or figma. I'm assuming this is an extension of radio-button from the figma.
| } | ||
| `} | ||
| > | ||
| <div className="font-medium">{option.label}</div> |
| > | ||
| <div className="font-medium">{option.label}</div> | ||
| {option.description && ( | ||
| <div |
| size === "sm" ? "text-xs" : "text-sm" | ||
| } text-ink-gray-5 mt-0.5`} | ||
| > | ||
| {option.description} |
Collaborator
There was a problem hiding this comment.
There is no description in the designs
| className={` | ||
| ${sizeClasses[size]} | ||
| ${themeClasses[theme]} | ||
| rounded-full border-2 |
Collaborator
There was a problem hiding this comment.
default state should have no border.
| ${themeClasses[theme]} | ||
| rounded-full border-2 | ||
| focus:outline-none focus-visible:ring-2 focus-visible:ring-outline-gray-3 | ||
| disabled:cursor-not-allowed disabled:opacity-50 |
Collaborator
There was a problem hiding this comment.
no-opacity changes in designs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces three new UI components—
Label,RadioGroup,Skeleton, andSeparator—to thefrappe-ui-reactpackage, each built on top of Radix UI primitives. It also adds their respective type definitions and comprehensive Storybook stories for documentation and testing. Additionally, the required Radix UI dependencies are added to the package manifest. These changes enhance the design system by providing configurable, accessible, and themable form and layout primitives.New Component Additions
Labelcomponent (src/components/label/index.tsx) supporting size, weight, variant, disabled, required, and optional props, with Radix UI integration.RadioGroupcomponent (src/components/radiogroup/index.tsx) with support for sizes, themes, variants, orientation, option descriptions, and disabled states, built on Radix UI.Separatorcomponent (src/components/separator/index.tsx) supporting size, color, variant, and orientation, leveraging Radix UI.Type Definitions
Label,RadioGroup,Skeleton, andSeparatorcomponents in their respectivetypes.tsfiles for type safety and IntelliSense.Storybook Documentation
LabelandRadioGroupcomponents to demonstrate usage, variants, and states, aiding in visual documentation and testing.Dependency Management
package.jsonto include new Radix UI dependencies required for the added components:@radix-ui/react-label,@radix-ui/react-radio-group, and@radix-ui/react-separator.