Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add @stylistic/jsx/jsx-closing-tag-location eslint rule #101

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

Pathan-Amaankhan
Copy link
Member

What

  • This PR will add @stylistic/jsx/jsx-closing-tag-location eslint rule. This rule will enforce the closing tag location for multiline JSX elements. [ 1, 'line-aligned' ] option will throw an error if the closing tag is not aligned with the line containing the opening tag.

Related Issue(s):

Testing Instructions

  • Run npm install && npm run lint.

Additional Info

  • As this PR fixes the codebase, we won't be getting any eslint errors.

Checklist

  • I have read the Contribution Guidelines.
  • My code is tested to the best of my abilities.
  • My code passes all lints (ESLint, tsc, prettier etc.).
  • My code has detailed inline documentation.
  • I have added unit tests to verify the code works as intended.
  • I have updated the project documentation as needed.
  • I have added a changeset for this PR using npm run changeset.

Copy link

changeset-bot bot commented Feb 25, 2025

⚠️ No Changeset found

Latest commit: b6381f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Pathan-Amaankhan Pathan-Amaankhan self-assigned this Feb 25, 2025
Copy link
Collaborator

@justlevine justlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tl;dr on hold until we can reevaluate whether @stylistic/jsx is something we want want to add as a whole.

https://github.com/orgs/rtCamp/projects/141/views/14?pane=issue&itemId=99390550

@justlevine justlevine added the status: hold ⏸️ Needs other items to be resolved before work can continue label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: hold ⏸️ Needs other items to be resolved before work can continue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants