-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: robust handling for internal uri #111
base: develop
Are you sure you want to change the base?
feat: robust handling for internal uri #111
Conversation
…environment variable to allow developers to specify the home URL and site URL individually.
# Conflicts: # packages/core/src/config/snapwp-config-manager.ts
🦋 Changeset detectedLatest commit: 7dc9e5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… cases for snapwp-config-manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The env vars for CI/CD are needed to be updated.
@justlevine This PR is up for re-review. |
(@justlevine audit env var names) |
(Also, dont forget to add a changelog) |
…to to-frontend-uri.ts, update logic for isInternalUrl
…o comment and spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are comments from an old code review. Not sure why they didn't get shared w. The rest, nor if they're still accurate 🤦♂️
I'll re-rereview tomorrow night
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last round of feedback from me (hopefully)
If @ayushnirwal has no suggestions for a utils naming convention, then I'll see what GPT recommends
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ta5r can you PTAL at the changes to the env variables (both documented and the comments that get output in the .env.example
), and make a matching PR for snapwp-helper
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged after @Ta5r updates the env vars in rtcamp/snapwp-helper
What
Why
Related Issue(s):
How
Checklist
npm run changeset
.