feat: Convert CLI to TypeScript#140
Conversation
🦋 Changeset detectedLatest commit: ac67767 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Swanand01
changed the title
…/snapwp into feat/migrate-cli-to-ts
packages/cli/package.json
Outdated
| "exports": { | ||
| ".": { | ||
| "import": "./dist/index.js", | ||
| "require": "./dist/index.js", | ||
| "types": "./dist/types/index.d.ts" | ||
| } | ||
| }, |
There was a problem hiding this comment.
There are no exports from this package. Only requirement is to add a "bin"
packages/cli/package.json
Outdated
| "resolve-tspaths": "*", | ||
| "tsc-watch": "*", | ||
| "typescript": "*", | ||
| "@snapwp/types": "*" |
There was a problem hiding this comment.
I see no imports from @snapwp/types
justlevine
left a comment
justlevine
left a comment
There was a problem hiding this comment.
I resolved the merge conflicts, but and then cleaned up the eslintrc file a bit more since different file types were sliding through. (ref: ef971fe)
@ayushnirwal please give it one last look through / approve before I go ahead and merge 🙇
Pull Request Test Coverage Report for Build 14358746936Details
💛 - Coveralls |
chore: Add `import/no-default-export` eslint rule.
| * @param config configuration. | ||
| * @param {string} source Import string. | ||
| * @param {string} file File-path in which alias is used. | ||
| * @param {Object} config configuration. |
There was a problem hiding this comment.
Was this file not included in the eslint config before?
5 participants
What
This PR converts the CLI to TypeScript.
Why
Typechecking. This is part of a larger effort to improve the CLI: https://github.com/rtCamp/headless/issues/408
Related Issue(s):
https://github.com/rtCamp/headless/issues/411
How
.cjs files are rewritten in TypeScript.
build.cjs is left as is, but the code has been updated to compile the rest of the TypeScript files.
Testing Instructions
Screenshots
Additional Info
Checklist
npm run changeset.