Skip to content

chore: Add jsdoc/require-param-type eslint rule#142

Merged
justlevine merged 21 commits intortCamp:developfrom
Ta5r:feat/jsdoc-require-param-type
Apr 3, 2025
Merged

chore: Add jsdoc/require-param-type eslint rule#142
justlevine merged 21 commits intortCamp:developfrom
Ta5r:feat/jsdoc-require-param-type

Conversation

@Ta5r
Copy link
Contributor

@Ta5r Ta5r commented Apr 2, 2025

What

Related Issue(s):

Testing Instructions

  • Run npm install && npm run lint.

Screenshots:

  • Before :
    temp

  • After :

Screenshot 2025-04-03 at 4 00 27 PM

Additional Info

  • As this PR fixes the codebase, we won't be getting any eslint errors.

Checklist

  • I have read the Contribution Guidelines.
  • My code is tested to the best of my abilities.
  • My code passes all lints (ESLint, tsc, prettier etc.).
  • My code has detailed inline documentation.
  • I have added unit tests to verify the code works as intended.
  • I have updated the project documentation as needed.
  • I have added a changeset for this PR using npm run changeset.

@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2025

🦋 Changeset detected

Latest commit: a8e39ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@snapwp/e2e-tests Patch
@snapwp/blocks Patch
@snapwp/query Patch
@snapwp/core Patch
@snapwp/next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Ta5r Ta5r force-pushed the feat/jsdoc-require-param-type branch from d33b6ae to 07a0a88 Compare April 3, 2025 07:59
@Ta5r Ta5r marked this pull request as ready for review April 3, 2025 08:57
@Ta5r Ta5r requested a review from justlevine April 3, 2025 09:09
@justlevine
Copy link
Collaborator

@Ta5r please update the PR title, and confirm type hinting is working with a screenshot in the PR description.

Then ping @/ayushnirwal for review 🙇‍♂️

@Ta5r Ta5r changed the title Feat/jsdoc require param type chore: Add jsdoc/require-param-type eslint rule Apr 3, 2025
@Ta5r Ta5r self-assigned this Apr 3, 2025
@Ta5r Ta5r requested a review from ayushnirwal April 3, 2025 10:38
Copy link
Collaborator

@justlevine justlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging so people can handle their merge conflicts in the Morning. @ayushnirwal if you spot anything that still needs to be handled, ask @Ta5r to do it in a follow-up PR

@justlevine justlevine merged commit c460b31 into rtCamp:develop Apr 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants