fix: avoid unnecessary favicon.ico requests when unset#152
Merged
justlevine merged 6 commits intortCamp:developfrom Apr 14, 2025
Merged
fix: avoid unnecessary favicon.ico requests when unset#152justlevine merged 6 commits intortCamp:developfrom
favicon.ico requests when unset#152justlevine merged 6 commits intortCamp:developfrom
Conversation
🦋 Changeset detectedLatest commit: dd51146 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 14432541899Details
💛 - Coveralls |
justlevine
approved these changes
Apr 10, 2025
Collaborator
justlevine
left a comment
There was a problem hiding this comment.
(not a real approval, confirming repo permissions, will reset and review shortly)
justlevine
reviewed
Apr 11, 2025
justlevine
reviewed
Apr 11, 2025
justlevine
reviewed
Apr 11, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
packages/next/src/root-layout/icons-metadata.ts:49
- Consider adding unit tests for the getIcons function to verify that it correctly returns the fallback icons when settings are undefined.
if ( ! settings ) { return fallbackIcons; }
packages/next/src/middleware/proxies.ts:25
- Consider adding unit tests to ensure that requests to '/favicon.ico' are correctly intercepted and return a 404 response.
if ( '/favicon.ico' === nextPath ) {
justlevine
reviewed
Apr 13, 2025
Collaborator
justlevine
left a comment
There was a problem hiding this comment.
Nothing else to add. I defer to @ayushnirwal for review/approval.
ayushnirwal
approved these changes
Apr 14, 2025
favicon.ico requests when unset.
favicon.ico requests when unset.favicon.ico requests when unset
This was referenced Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How
Checklist
npm run changeset.