-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable tsconfig's verbatimModuleSyntax
#65
chore: enable tsconfig's verbatimModuleSyntax
#65
Conversation
If someone could pick this up and fix the ts-jest issues 🙇: https://jestjs.io/docs/ecmascript-modules |
feaeef6
to
ef726d2
Compare
(Rebased on #64) |
ef726d2
to
a217983
Compare
|
(Rebased on #66) |
verbatimModuleSyntax
and fix type importsverbatimModuleSyntax
What
Enables TSConfig's
verbatimModuleSyntax
, which requires types to be imported using thetype
keyword.Then remediates all violations of type imports.
Why
Not explicitly marking imported types can cause headaches in consuming projects, ides, incorrect codesplitting and compiling etc.
Related Issue(s):
Part of https://github.com/rtCamp/headless/issues/317
How
Testing Instructions
Screenshots
Additional Info
Interestingly, errors are only caught during
npm run build
, sincenpm run typecheck
uses the--noEmit
flag.Not sure if this is important, but since our CI builds before it typechecks, I'm personally not bothered by it.
Checklist