Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: enable noUncheckedIndexedAccess and remediate exposed issues #67

Merged

Conversation

justlevine
Copy link
Collaborator

@justlevine justlevine commented Feb 14, 2025

What

This PR enables noUncheckedIndexedAccess and attempts to remediate the exposed smells

Why

Related Issue(s):

Part of https://github.com/rtCamp/headless/issues/317

How

See the commit history. Each remediation occurs in its own commit.

Testing Instructions

Screenshots

Additional Info

Checklist

  • I have read the Contribution Guidelines.
  • My code is tested to the best of my abilities.
  • My code passes all lints (ESLint, tsc, prettier etc.).
  • My code has detailed inline documentation.
  • I have added unit tests to verify the code works as intended.
  • I have updated the project documentation as needed.
  • I have added a changeset for this PR using npm run changeset.

Copy link

changeset-bot bot commented Feb 14, 2025

⚠️ No Changeset found

Latest commit: aeebfed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@justlevine
Copy link
Collaborator Author

Would appreciate confirmation that I'm handling these type changes correctly 🙇

@justlevine justlevine self-assigned this Feb 17, 2025
@justlevine justlevine merged commit 58fb993 into rtCamp:develop Feb 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants