Rename parameter classes for consistency: update 'Params' to 'Config'…

[egenn]

… in Resampler subclasses

[gemini-code-assist]

Summary of Changes

Hello @egenn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing code consistency and clarity within the Resampler framework by standardizing the naming of parameter-related classes. The change involves renaming all *Params classes to *Config to better reflect their role as configuration objects. This refactoring improves readability and maintainability, with all necessary updates to class definitions, instantiation logic, and unit tests to ensure seamless integration and correct behavior.

Highlights

• Class Renaming: All Resampler subclass parameter classes, such as KFoldParams, StratSubParams, BootstrapParams, StratBootParams, LOOCVParams, and CustomParams, have been consistently renamed to use the Config suffix (e.g., KFoldConfig).
• Function Updates: The setup_Resampler function has been updated to instantiate and refer to the newly renamed *Config classes, ensuring proper functionality with the new naming convention.
• Test Suite Alignment: Corresponding unit tests in test_Resampler.R have been modified to reflect the new *Config class names, ensuring that all tests pass with the updated class structure.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request consistently renames the resampler parameter classes from ...Params to ...Config for better consistency with the ResamplerConfig superclass. The changes are applied correctly across the class definitions and their usages in the setup_Resampler function. The corresponding tests are also updated to reflect these changes. I've added one suggestion to improve the robustness of the tests by checking for property values in addition to the class type. Overall, this is a good refactoring that improves code clarity.

[gemini-code-assist]

This test correctly checks the class of the created object. To make it more robust, I recommend also asserting that the object's properties are initialized with the correct values. This provides a stronger guarantee that the constructor is working as expected. This principle can be applied to other similar tests in this file.

  expect_s7_class(rsp, StratSubConfig)
  expect_equal(rsp@n, 10L)
  expect_equal(rsp@train_p, 0.75)