Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a Makefile to automate development tasks such as documentation, installation, and testing, while updating .Rbuildignore to exclude it. It also modifies verbosity logic in the messaging functions and fixes a typo in a comment within the utility checks. Review feedback identifies a bug in the msg0 function where the verbosity check is inconsistent with msg, potentially allowing output when it should be silent. Additionally, it is recommended to include the document target in the Makefile's .PHONY list.
There was a problem hiding this comment.
Pull request overview
This PR focuses on repository cleanup and developer/CI ergonomics by adding a Makefile for common package tasks and modernizing the GitHub Actions R CMD check workflow, along with a couple of small R code cleanups.
Changes:
- Add a
Makefileto standardize common tasks (document, install, test, site) and ignore it in R builds. - Update the GitHub Actions
R-CMD-checkworkflow (trigger rules, concurrency, pandoc setup, snapshot upload, build args). - Minor R code tweaks: fix a closing comment label and adjust message verbosity guards.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| R/utils_checks.R | Corrects the end-of-function comment for check_float01exc. |
| R/msg.R | Adjusts verbosity handling in msg() / msg0() (one change introduces a behavior regression). |
| Makefile | Adds make targets for documenting, installing, testing, and building pkgdown site. |
| .Rbuildignore | Ensures Makefile is excluded from the package build. |
| .github/workflows/R-CMD-check.yaml | Modernizes CI configuration and enables snapshot artifact upload + build args. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.