Skip to content

Fix negative timestamps parsing incorrectly #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix negative timestamps parsing incorrectly #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
"elm/time": "1.0.0 <= v < 2.0.0"
},
"test-dependencies": {
"elm-explorations/test": "1.0.0 <= v < 2.0.0"
"elm-explorations/test": "2.0.0 <= v < 3.0.0"
Copy link
Contributor Author

@jamesrweb jamesrweb Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required change for the elm-test command to run.

}
}
2 changes: 1 addition & 1 deletion src/Iso8601.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ utcOffsetInMinutes =
utcOffsetMinutesFromParts : Int -> Int -> Int -> Int
utcOffsetMinutesFromParts multiplier hours minutes =
-- multiplier is either 1 or -1 (for negative UTC offsets)
multiplier * (hours * 60) + minutes
multiplier * ((hours * 60) + minutes)
Copy link
Contributor Author

@jamesrweb jamesrweb Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual fix to correct the implementation.

in
Parser.succeed identity
|= oneOf
Expand Down
11 changes: 10 additions & 1 deletion tests/Example.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ module Example exposing (knownValues, reflexive)
import Expect
import Fuzz
import Iso8601
import Json.Decode exposing (decodeString, errorToString)
Copy link
Contributor Author

@jamesrweb jamesrweb Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically sorted by elm-format.

import Test exposing (..)
import Time
import Json.Decode exposing (decodeString, errorToString)


knownValues : Test
Expand Down Expand Up @@ -99,11 +99,20 @@ knownValues =
\_ ->
Iso8601.toTime "2019-05-30T06:30"
|> Expect.equal (Ok (Time.millisToPosix 1559197800000))
, test "toTime supports negative timestamps (French Polynesia: Marquesas Islands)" <|
Copy link
Contributor Author

@jamesrweb jamesrweb Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases for the examples provided by @pd9333 in #31.

\_ ->
Iso8601.toTime "2022-11-21T00:00:00-09:30"
|> Expect.equal (Ok (Time.millisToPosix 1669023000000))
, test "toTime supports negative timestamps (Canada: Newfoundland, Labrador (southeast))" <|
\_ ->
Iso8601.toTime "2022-11-21T00:00:00-03:30"
|> Expect.equal (Ok (Time.millisToPosix 1669001400000))
, test "decoder returns clearer error for dead ends" <|
\_ ->
case decodeString Iso8601.decoder "2010-09-31T14:29:25.01235Z" of
Err error ->
Expect.notEqual (errorToString error) "TODO deadEndsToString"

Ok _ ->
Expect.fail "Should fail on dead ends"
]
Expand Down