Skip to content

Feature/ like-save songs#10

Open
ashikvarma11 wants to merge 5 commits intortkg12:masterfrom
ashikvarma11:feature/like-save-songs
Open

Feature/ like-save songs#10
ashikvarma11 wants to merge 5 commits intortkg12:masterfrom
ashikvarma11:feature/like-save-songs

Conversation

@ashikvarma11
Copy link

What I did so far

  • Added API calls for fetching saved-tracks, add and remove saved-tracks from the user's library.
  • Added 💚 icon for like/save. Toggling adds/removes tracks from the user's library.
  • Added ❗ icon for tracks where the preview is not available.

TO DO

  • Log in checks while saving a track.

@ashikvarma11 ashikvarma11 changed the title Feature/like save songs Feature/ like-save songs Oct 1, 2020
@ashikvarma11 ashikvarma11 marked this pull request as ready for review October 1, 2020 14:45
@ashikvarma11
Copy link
Author

@rtkg12 Please guide me through the login checks.

@rtkg12
Copy link
Owner

rtkg12 commented Oct 22, 2020

Hey @ashikvarma11, sorry I haven't gotten a chance to review the PR yet. For login checks, you can use the access_token cookie to check if the user is currently logged in. If not, you can handle it in a similarly to saving a playlist when a user is not logged in. Or, if you prefer, you could just hide the icons for liking the songs when a user isn't logged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants