Merge my latest changes into yours#2
Closed
dosier wants to merge 5 commits into
Closed
Conversation
… package and update imports across modules. Add coroutines dependency to `prompt-model`.
# Conflicts: # prompt/prompt-executor/prompt-executor-clients/prompt-executor-anthropic-client/src/commonMain/kotlin/ai/koog/prompt/executor/clients/anthropic/AnthropicLLMClient.kt # prompt/prompt-executor/prompt-executor-clients/prompt-executor-google-client/src/commonMain/kotlin/ai/koog/prompt/executor/clients/google/GoogleLLMClient.kt # prompt/prompt-executor/prompt-executor-clients/prompt-executor-openai-client/src/commonMain/kotlin/ai/koog/prompt/executor/clients/openai/OpenAILLMClient.kt # prompt/prompt-model/src/commonMain/kotlin/ai/koog/prompt/streaming/StreamFrameExt.kt
Author
|
Regarding dosier#1 |
Author
|
Okay I think we should disregard the partial tool calls, openAI API specs seems to emit a tool call after it finished all the chunks that does contain the final tool call. Would simplify the API a lot. |
Author
|
Removed partial streaming in this version: #3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using new flow extensions to construct streams, removing index tool call usage for non-streaming responses.
Also after looking at the api of other LLM clients, it seems only openAI does the partial tool call stream objects... So I think it's better to have two types,
ToolCall.PartialandToolCall.Completedand offer extensions to mergeToolCall.PartialintoToolCall.Completed.