-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring #1455
Open
githubCast
wants to merge
19
commits into
rubenlagus:dev
Choose a base branch
from
githubCast:feature/refactor_TelegramClient_SpringLongPollingBot
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactoring #1455
githubCast
wants to merge
19
commits into
rubenlagus:dev
from
githubCast:feature/refactor_TelegramClient_SpringLongPollingBot
+2,502
−977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
githubCast
commented
Nov 16, 2024
- moved botToken to TelegramClient
- replaced getBotToken with getTelegramClient in SpringLongPollingBot
- replaced getBotToken with getTelegramClient in SpringLongPollingBot
Loading status checks…
What's the benefits of this refactor? Not sure what it adds |
Loading status checks…
…ubenlagus#1438) Co-authored-by: Ruben Bermudez <[email protected]>
Loading status checks…
Encapsulation: client contains all the necessary parameters to communicate with the server. |
Loading status checks…
Loading status checks…
…s#1434) Co-authored-by: Ruben Bermudez <[email protected]>
Loading status checks…
…lingBot
Loading status checks…
…lingBot
Loading status checks…
…lingBot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.