Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring #1455

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from

Conversation

githubCast
Copy link

  • moved botToken to TelegramClient
  • replaced getBotToken with getTelegramClient in SpringLongPollingBot

valkuc and others added 5 commits September 7, 2024 12:16

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- replaced getBotToken with getTelegramClient in SpringLongPollingBot
@rubenlagus
Copy link
Owner

What's the benefits of this refactor? Not sure what it adds

panic08 and others added 4 commits November 19, 2024 23:52

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ubenlagus#1438)

Co-authored-by: Ruben Bermudez <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@githubCast
Copy link
Author

What's the benefits of this refactor? Not sure what it adds

Encapsulation: client contains all the necessary parameters to communicate with the server.

panic08 and others added 3 commits November 21, 2024 22:23

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…s#1434)

Co-authored-by: Ruben Bermudez <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@rubenlagus rubenlagus changed the base branch from master to dev November 23, 2024 18:31
rubenlagus and others added 7 commits November 23, 2024 18:33

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…lingBot

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…lingBot

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…lingBot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants