Replace GW2DB and add item/recipe tooltips from Official API #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m for description. More to come still.
This will now generate the tooltips (not hover ones yet) for all item types known so far. It also caches API queries.
Also added in some stub code for Bag.php.
They will now show Runes/Sigils, and share a common Equipment class now. The tooltips are also much closer to what they are in game as well.
Further refined all tooltips with more information to make them more like the ones in game.
Consumables are now much closer to the tooltip in game. Also started looking into the hover tooltips.
… an item. It's currently being used on the item-list page to generate tooltips when hovering over an item. The javascrupt has had some ugly hacks applied to it to get this working. It's basically the definition of ugly, but it works.
…y popup when hovering the link and not the whole row.
Did some aggressive removal of GW2DB references. Still need to do more to have recipe tooltips it turns out.
Also had further cleanup, and removal of more GW2DB references.
…e giver's sets and possibly other old Magic Find items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather large pull request.
It will completely remove all references to GW2DB, including a table, and some columns in the database. (Run config/migrations/20130914.remove_gw2db.sql )
It also uses the official GW2 API to show tooltips for items/recipes. This includes hovering over items.
Also, if you could please take a look at the autoload.php for me? For some reason I just can't get it autoloading the new GW2Spidy\GW2API namespace, so I added in a bunch of manually included files for now.
Let me know on IRC if you have any questions about this pull request.