Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concat & minify/uglify CSS and JS files. Remove whitespace from HTML. #150

Merged
merged 3 commits into from
Jun 25, 2014
Merged

Concat & minify/uglify CSS and JS files. Remove whitespace from HTML. #150

merged 3 commits into from
Jun 25, 2014

Conversation

williamboman
Copy link
Contributor

Added Grunt tasks (see title). Useful for production.

A GIF for demonstration;
untitled

…ll as updating the references in wrapper.html.twig.

Now prints every page without whitespace.
… templates/dist as well as changing the Twig template path in webroot/index.php.

Added unbuild task.
@rubensayshi
Copy link
Owner

Hey @williamboman I've got plenty of experience using grunt, just never got around to adding it to gw2spidy, thanks for the PR, I need a moment to take a look at it but I'm so insanely busy with my current start-up that it might take another week :S

@rubensayshi rubensayshi merged commit 5541965 into rubensayshi:master Jun 25, 2014
@rubensayshi
Copy link
Owner

Sorry for being so awefully slow, it's against all my believes to let a PR hang for so long because people who contrib should at the very least be rewarded with a fast response time ...
But I was sooo freaking busy :-(

Anyway, I've changed it so that the lists the scripts that go into each bundle are in the Gruntfile and are compiled into webroot/assets/compiled so that it doesn't touch the files itself and most important; I can keep using the versioned_assets helper because that makes sure that the URL contains a version for the varnish reverse proxy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants