Map the Rarity "Basic" back to the old "Common" #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is needed due to the fact that the old TP-API used "Common" as second lowest rarity type. The v2 API however uses "Basic".
rubensayshi
added a commit
that referenced
this pull request
Oct 7, 2014
Map the Rarity "Basic" back to the old "Common"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed due to the fact that the old TP-API used "Common" as second lowest rarity type. The v2 API however uses "Basic".
I also forgot to mention that we now check the http code that is returned and cancel the operation, if an exit code different than 200 is returned.