Get the Gem Exchange dta from the official GW2 API #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this was the spider to use gw2 sessions, they are now removed as well. There have been some other cleanups as well. List of changes: - remove item-db worker from start-workers.sh - remove some now unused urls from the default config - do not route /admin/session POST anymore. We don't use them anymore anyways - don't try to log into a gw2 session anymore in worker-gem - remove some unused use statements - remove session related functions from the base spider and add a central function to retrieve API data - use the official gw2 API to retrieve gem exchange data - remove gw2 session related classes and the old TradingPostSpider - change the admin_session template to inform the caller that it's not used anymore.
This version includes documentation changes for the updats gem-worker, an added section to install grunt and some minor changes (some hard linewarps among others).
Make getApiData Exception text less specific.
rubensayshi
added a commit
that referenced
this pull request
Nov 24, 2014
Get the Gem Exchange dta from the official GW2 API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last call to the old TP-API. Thus the Pull Request not only switching the Gem Exchange to the new API but also deletes a number of classes and configurations that only mattered to the old API.