Master #175
Closed
Master #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The puppet stage of the provisioning by vagrant now also installs node.js and grunt. This is needed for the following call of bin/update.sh to make sure all js and css files are available.
This prevents us from using any public Type/Subtype/Rarity IDs. We create our own, if we encounter a new type, but that means, we can't make sure, IDs are stable in dev environments. We should probably check in a SQL-File with "our" ID->Title tables. Disable instance pooling of Propel, because we will get memory problems otherwise...
Puppet will now: - import known types, sub-types and disciplines. That way we keep our IDs stable - clear our caches and set the request slots up - run tools/update-items-from-api.php to get the initial batch of items. Due to the amount of items, the provisioning will take quite some time and php will be swapping a lot in the end...
These classes are only slightly changed copies from the v1 API. Using the v2 API shortens the update-items-from-api.php by about a third.
This commit finishes the move to the v2/items-API of GW. We can now: - nix the ItemDB-Queue (which happened, the workers will output a message and exit with code 1) - use tools/update-items-from-api.php for item updates. The script runs about 5 minutes and creates new (Sub)Types if needed. I also adapted the Readme.
This is needed to be able to put the back items into the item listings queue. More adaptions to the Readme and disable instance pooling for propel on importing the recipe map... That prevents swapping and makes the import faster by a HUGE amount.
This change is needed due to the fact that the old TP-API used "Common" as second lowest rarity type. The v2 API however uses "Basic".
Map the Rarity "Basic" back to the old "Common"
The ingredient tree and shopping list should now show tooltips again instead of "loading" indefinitely.
Fix keneanung/#3
Since this was the spider to use gw2 sessions, they are now removed as well. There have been some other cleanups as well. List of changes: - remove item-db worker from start-workers.sh - remove some now unused urls from the default config - do not route /admin/session POST anymore. We don't use them anymore anyways - don't try to log into a gw2 session anymore in worker-gem - remove some unused use statements - remove session related functions from the base spider and add a central function to retrieve API data - use the official gw2 API to retrieve gem exchange data - remove gw2 session related classes and the old TradingPostSpider - change the admin_session template to inform the caller that it's not used anymore.
This version includes documentation changes for the updats gem-worker, an added section to install grunt and some minor changes (some hard linewarps among others).
Make getApiData Exception text less specific.
Get the Gem Exchange dta from the official GW2 API
Some minor changes
|
ehm something went wrong here? you created a PR to merge |
|
@rubensayshi yea... considering they still have a defualt avi (like me) they're prolly still realitively new here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRY