Merge pull request #38 from rubocop/fix-association-style-error

Fix AssociationStyle for blockless factory definitions

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Master (Unreleased)
 
+- Fix `FactoryBot/AssociationStyle` cop for a blockless `factory`. ([@pirj])
+
 ## 2.23.0 (2023-05-15)
 
 - Add `FactoryBot/FactoryAssociationWithStrategy` cop. ([@morissetcl])

lib/rubocop/cop/factory_bot/association_style.rb

@@ -144,7 +144,7 @@ def bad_associations_in(node)
         end
 
         def children_of_factory_block(node)
-          block = node.parent
+          block = node.block_node
           return [] unless block
           return [] unless block.body
 

spec/rubocop/cop/factory_bot/association_style_spec.rb

@@ -15,7 +15,9 @@ def inspected_source_filename
     context 'when factory block is empty' do
       it 'does not register an offense' do
         expect_no_offenses(<<~RUBY)
-          factory :user do
+          FactoryBot.define do
+            factory :user do
+            end
           end
         RUBY
       end
@@ -24,16 +26,21 @@ def inspected_source_filename
     context 'with when factory has no block' do
       it 'does not register an offense' do
         expect_no_offenses(<<~RUBY)
-          factory :user
+          FactoryBot.define do
+            factory :user
+            factory :admin_user, parent: :user
+          end
         RUBY
       end
     end
 
     context 'when implicit style is used' do
       it 'does not register an offense' do
         expect_no_offenses(<<~RUBY)
-          factory :article do
-            user
+          FactoryBot.define do
+            factory :article do
+              user
+            end
           end
         RUBY
       end