Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing missing block argument in sequence operator #50

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

doriantaylor
Copy link
Contributor

Found this crash scenario. Apparently I had fixed this months ago and not submitted?

@coveralls
Copy link

Coverage Status

coverage: 88.863%. remained the same
when pulling ad4e51d on doriantaylor:missing-block
into 989964c on ruby-rdf:develop.

@gkellogg
Copy link
Member

Great, thanks! Have you noticed other places where a block is expected but not defined?

@gkellogg gkellogg added the bug label Feb 17, 2024
@gkellogg
Copy link
Member

My examination shows a number of operators that don't have a block argument, but these are all for Update, rather than Query, so this seems the only one that needs to be addressed.

@gkellogg gkellogg merged commit 8496631 into ruby-rdf:develop Feb 17, 2024
8 checks passed
@doriantaylor
Copy link
Contributor Author

I didn't go looking for other missing blocks because I'm right in the middle of something but I can make a note to circle back and check later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants