Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to states #463

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Add types to states #463

merged 3 commits into from
Jul 30, 2024

Conversation

Little-Rubyist
Copy link
Contributor

This is the type definition of Item.rb added in this PR.

@@ -56,11 +56,11 @@ def new_by_next_position
Item.new(rule: rule, position: position + 1)
end

def symbols_before_dot
def symbols_before_dot # steep:ignore
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array#[] is nullable but symbols_before_dot and symbols_after_dot are not.
But I couldn't make Array#[] temporarily not null, so I added steep:ignore .

Copy link
Collaborator

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ydah ydah merged commit 755a547 into ruby:master Jul 30, 2024
16 checks passed
@Little-Rubyist Little-Rubyist deleted the add_types_to_states branch July 30, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants