-
Notifications
You must be signed in to change notification settings - Fork 35
🔥 Use psych (>= 5.2.5) for encoding Data objects #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
787394a to
19998e1
Compare
|
@eregon It looks like TruffleRuby doesn't like the I guess TruffleRuby will either need to support a compatible |
|
Could you file an issue at https://github.com/truffleruby/truffleruby/issues ? |
19998e1 to
b43d315
Compare
b43d315 to
863d005
Compare
This _is_ a breaking change, because objects that would previously encode with a `ruby/object:Net::IMAP::DataSubclass` tag will instead encode with a `ruby/data:Net::IMAP::DataSubclass` tag. Any YAML with the old tag will create an (effectively) empty data object: the data members will not be initialized (but ivars will be set).
863d005 to
183acc1
Compare
|
This deleted |
The target of this test file has been delete by ruby#543.
The target of this test file has been deleted by ruby#543.
Delete test/net/imap/test_data_lite.rb, because the target of this test file has been deleted by [ruby/net-imap#543]. [ruby/net-imap#543]: ruby/net-imap#593
Depends on #541, which drops the
Datapolyfill.Unlike #541, this is a breaking change, because objects that would previously encode with a
ruby/object:Net::IMAP:DataSubclasstag will instead encode with aruby/data:Net::IMAP:DataSubclasstag. Any YAML with the old tag will create an (effectively) empty data object: the data members will not be initialized (but ivars will be set).