Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rust code out of build.rs and into lib.rs #3458

Conversation

segiddins
Copy link
Contributor

It is easier to follow non-templated rust code when it is in the source file rather than a string

@kddnewton
Copy link
Collaborator

Hey @segiddins! I'm not opposed to this change, but can you take a look at the failures on this PR?

@segiddins segiddins force-pushed the segiddins/move-rust-code-out-of-build.rs-and-into-lib.rs branch from 7a0aaf6 to 6579a85 Compare February 13, 2025 17:59
It is easier to follow non-templated rust code when it is in the source file rather than a string

Signed-off-by: Samuel Giddins <[email protected]>
@segiddins segiddins force-pushed the segiddins/move-rust-code-out-of-build.rs-and-into-lib.rs branch from 6579a85 to 60edd13 Compare February 13, 2025 18:10
Copy link
Collaborator

@kddnewton kddnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kddnewton kddnewton merged commit 8aa66d0 into ruby:main Feb 13, 2025
58 of 59 checks passed
@segiddins segiddins deleted the segiddins/move-rust-code-out-of-build.rs-and-into-lib.rs branch February 13, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants