Move rust code out of build.rs and into lib.rs #3458
Merged
+256
−251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @segiddins! I'm not opposed to this change, but can you take a look at the failures on this PR? |
segiddins
force-pushed
the
segiddins/move-rust-code-out-of-build.rs-and-into-lib.rs
branch
from
7a0aaf6 to
6579a85
Compare
It is easier to follow non-templated rust code when it is in the source file rather than a string Signed-off-by: Samuel Giddins <[email protected]>
segiddins
force-pushed
the
segiddins/move-rust-code-out-of-build.rs-and-into-lib.rs
branch
from
6579a85 to
60edd13
Compare
segiddins
deleted the
segiddins/move-rust-code-out-of-build.rs-and-into-lib.rs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is easier to follow non-templated rust code when it is in the source file rather than a string