core: Array#include? and Enumerable#include? should take non-Elem types #2273
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, `Array[Integer]` can take other number types validly: ``` > [1, 2, 3].include? 2.0 => true > [1, 2, 3].include? Complex(2) => true > [1, 2, 3].include? Rational(2) => true ``` refs: soutaro/steep#1482
|
In reality, it seems that the irb(main):005> TracePoint.new(:a_call) { |tp| p tp }.enable { [1, 2, 3].include? 2.0 }
#<TracePoint:b_call (irb):5>
#<TracePoint:c_call 'include?' (irb):5>
#<TracePoint:c_call '==' (irb):5>
#<TracePoint:c_call '==' (irb):5>
=> trueHowever, since |
tk0miya
commented
Feb 12, 2025
| @@ -2182,7 +2182,7 @@ class Array[unchecked out Elem] < Object | |||
| # | |||
| # Related: see [Methods for Querying](rdoc-ref:Array@Methods+for+Querying). | |||
| # | |||
| def include?: (Elem object) -> bool | |||
| def include?: (untyped object) -> bool | |||
There was a problem hiding this comment.
Initially, I thought to allow taking nil value. Therefore I changed this type as follows once:
Suggested change
| def include?: (untyped object) -> bool | |
| def include?: (Elem? object) -> bool | |
| | (untyped object) -> false |
But I noticed it does not help the numbers' case. Therefore, I used untyped here finally.
|
I prefer keeping the strict method type, because finding a code passing an unexpected object to Can you share the code where you want this? @tk0miya |
|
Ah, soutaro/steep#1482... %w,true,.include?(ENV['foo'])Hmm... |
|
No conclusion yet, though I'm not very positive about this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
Array[Integer]can take other number types validly:refs: soutaro/steep#1482