Attempt to address volunteer#create invalid email error in bot-bugsag

[7riumph]

What github issue is this PR for, if any?

Resolves #NaN

Noticed an error with volunteers#create through the discord.

Likely due to an invalid or non standard email.

I refactored it to ensure in the volunteers_controller create function....

• Emails are not blank
• Emails are properly formatted (regex)

Before an invite can be sent to the user.

[compwron]

good

[compwron]

Needs specs but a good start!

[FireLemons]

The regex addition didn't solve the real life error case of an email address with a close parentheses at the end [email protected]) and I think it's because it's technically a correct email format according to the RFC URI::MailTo::EMAIL_PATTERN is based off of so instead I think it's better to error handle email send attempts.

for volunteers_controller.rb:35

    if @volunteer.save
      @volunteer.invite!(current_user)
      # call short io api here
      invitation_url = Rails.application.routes.url_helpers.accept_user_invitation_url(invitation_token: @volunteer.raw_invitation_token, host: request.base_url)

I suggest wrapping @volunteer.invite!(current_user) in a try catch so not only does it catch emails with invalid formats i.e. [email protected])(from bugsnag) but it will also catch domains and email addresses that don't exist