Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On new/edit donation, Money raised in dollars must be non-negative. #5065

Open
2 tasks
cielf opened this issue Mar 5, 2025 · 1 comment · May be fixed by #5092
Open
2 tasks

On new/edit donation, Money raised in dollars must be non-negative. #5065

cielf opened this issue Mar 5, 2025 · 1 comment · May be fixed by #5092
Labels
Good First Issue Suitable for users that are newer or less experienced

Comments

@cielf
Copy link
Collaborator

cielf commented Mar 5, 2025

Summary

Prevent negative values from being used in money raised field in donations

Why?

This is mostly a hygiene change, but It's not a donation if the essentials bank is paying for it .

Details

The first screen in question is reached if you:
Sign in as [email protected]
Click on Donation
Click on New Donation
The field is labelled "Money raised in dollars"

The second screen in question is reached if you:

Sign in as [email protected]
Click on Donation
Click on All Donations
Click View beside a donation
Click "Make a correction"
The field is labelled "Money raised in dollars"

You should not be able to enter a negative value in either of these places.
Updating the validation on the model level should take care of both of them, but please confirm.

Criteria for completion

  • Behaviour as described above
  • automated tests to support the behaviour
@cielf cielf added Good First Issue Suitable for users that are newer or less experienced SCALE2025 and removed SCALE2025 labels Mar 5, 2025
@mateusmsf94
Copy link

I can work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for users that are newer or less experienced
Projects
None yet
2 participants