Add validation for money_raised in Donation model to ensure it is non… #5092
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-negative, and update related tests for validation errors in request specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5065
Description
This pull request addresses issue #5065 by adding validation to ensure that the
money_raisedattribute in theDonationmodel cannot be negative. This change was motivated by the need to prevent invalid data entry that could lead to incorrect financial reporting. The solution involves adding a numericality validation to themoney_raisedattribute and updating the request specs to test for this validation.Type of change
How Has This Been Tested?
The changes have been tested by adding new unit tests in
spec/models/donation_spec.rbto verify that themoney_raisedattribute cannot be negative. Additionally, request specs inspec/requests/donations_requests_spec.rbhave been updated to ensure that the correct validation error messages are flashed when attempting to create or update a donation with a negativemoney_raisedvalue. These tests can be run usingbundle exec rake, orbundle exec rspec spec/requests/donations_requests_spec.rbandbundle exec rspec spec/models/donation_spec.rbto verify that all validations and error messages are functioning as expected.