#4739: Fix product drive delete (updated)

app/controllers/product_drives_controller.rb

@@ -76,10 +76,13 @@ def update
   end
 
   def destroy
-    current_organization.product_drives.find(params[:id]).destroy
-    respond_to do |format|
-      format.html { redirect_to product_drives_url, notice: 'Product drive was successfully destroyed.' }
-      format.json { head :no_content }
+    result = ProductDriveDestroyService.call(@product_drive, current_user, current_organization)
+
+    if result.success?
+      redirect_to product_drives_url, notice: result.value
+    else
+      flash[:error] = result.error
+      redirect_back(fallback_location: product_drives_url)
     end
   end
 

app/services/product_drive_destroy_service.rb

@@ -0,0 +1,29 @@
+class ProductDriveDestroyService
+  class << self
+    def call(product_drive, user, organization)
+      return Result.new(error: "You are not allowed to perform this action.") unless verify_role(user, organization)
+
+      unless can_destroy?(product_drive, user)
+        product_drive.errors.add(:base, "Cannot delete product drive with donations.")
+        raise ActiveRecord::RecordInvalid.new(product_drive)
+      end
+
+      if product_drive.destroy
+        Result.new(value: "Product drive was successfully destroyed.")
+      else
+        raise ActiveRecord::RecordNotDestroyed.new("Failed to destroy product drive", product_drive)
+      end
+    end
+
+    def can_destroy?(product_drive, user)
+      return false unless user.has_role?(Role::ORG_ADMIN, product_drive.organization)
+      product_drive.donations.empty?
+    end
+
+    private
+
+    def verify_role(user, organization)
+      user.has_role?(Role::ORG_ADMIN, organization)
+    end
+  end
+end

app/views/product_drives/show.html.erb

@@ -90,7 +90,7 @@
           </p>
           <div class="card-footer clearfix">
             <%= edit_button_to edit_product_drive_path(@product_drive), { text: "Make a correction", size: "md" } %>
-            <%= delete_button_to product_drive_path(@product_drive), { confirm: "Are you sure you want to permanently remove this product drive?", size: "md" } if current_user.has_role?(Role::ORG_ADMIN, current_organization) %>
+            <%= delete_button_to product_drive_path(@product_drive), { confirm: "Are you sure you want to permanently remove this product drive?", size: "md", enabled: ProductDriveDestroyService.can_destroy?(@product_drive, current_user)} %>
           </div>
           <!-- /.card-footer-->
         </div>