-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Rails 8 #5046
base: main
Are you sure you want to change the base?
Upgrade to Rails 8 #5046
Conversation
I think we discussed this in the planning meeting a few weeks back and were deliberately going to wait for a while before going forward with Rails 8. @dorner - does that match your recollection? |
I think that was for Ruby 3.3 / 3.4. Rails 8 should be safe to update. I'll take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be safe to update filterrific now.
@dorner I don't know enough about Rails 8 to intelligently comment -- but given the potentially large number of first time contributors from Scale, and that this feels like a "we should exercise most things" kind of change, I suggest we postpone merging it until next week. |
@dorner The annotate gem wasn't working with Rails 8, and upon investigation it has been abandoned. I migrated to the recommended replacement annotaterb. The main difference being it uses a yaml file for configuration, hence the changes seen in this PR |
Doesn't resolve any issue.
Description
rails
from 7.2.2 to 8.0.1filterrific
to be compatible with Rails 8paper_trail
to be compatible with Rails 8annotate
toannotaterb
becauseannotate
doesn't support Rails 8 and it is abandonedType of change
How Has This Been Tested?
I did some light testing locally, and all the tests are passing. But we probably want to test this a little more thoroughly and in staging too.