Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rails 8 #5046

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Upgrade to Rails 8 #5046

wants to merge 10 commits into from

Conversation

coalest
Copy link
Collaborator

@coalest coalest commented Feb 27, 2025

Doesn't resolve any issue.

Description

  • Upgraded rails from 7.2.2 to 8.0.1
  • Upgraded filterrific to be compatible with Rails 8
  • Upgraded paper_trail to be compatible with Rails 8
  • Added a workaround that fixes a Devise issue causing tests to fail with rails 8
  • Migrate from annotate to annotaterb because annotate doesn't support Rails 8 and it is abandoned

Type of change

  • Dependency update (shouldn't affect users in theory)

How Has This Been Tested?

I did some light testing locally, and all the tests are passing. But we probably want to test this a little more thoroughly and in staging too.

@cielf
Copy link
Collaborator

cielf commented Feb 28, 2025

I think we discussed this in the planning meeting a few weeks back and were deliberately going to wait for a while before going forward with Rails 8. @dorner - does that match your recollection?

@dorner
Copy link
Collaborator

dorner commented Mar 5, 2025

I think that was for Ruby 3.3 / 3.4. Rails 8 should be safe to update. I'll take a look.

Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be safe to update filterrific now.

@cielf
Copy link
Collaborator

cielf commented Mar 5, 2025

@dorner I don't know enough about Rails 8 to intelligently comment -- but given the potentially large number of first time contributors from Scale, and that this feels like a "we should exercise most things" kind of change, I suggest we postpone merging it until next week.

@coalest
Copy link
Collaborator Author

coalest commented Mar 5, 2025

@dorner The annotate gem wasn't working with Rails 8, and upon investigation it has been abandoned. I migrated to the recommended replacement annotaterb. The main difference being it uses a yaml file for configuration, hence the changes seen in this PR

@coalest coalest requested a review from dorner March 10, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants