-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5037 default the quantity per individual to 50 in the data #5080
Open
nathangthomas
wants to merge
6
commits into
rubyforgood:main
Choose a base branch
from
nathangthomas:5037-default-the-quantity-per-individual-to-50-in-the-data
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7f13603
Add migration to set default distribution quantity
nathangthomas b16d0de
Set default distribution quantity in after_initialize if new record
nathangthomas a8ed397
Display default value in the form
nathangthomas dac2402
Add tests
nathangthomas e246d88
Remove changes to form view
nathangthomas 0656e77
Remove unecessary valid? call
nathangthomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
db/migrate/20250307161544_set_default_distribution_quantity.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
class SetDefaultDistributionQuantity < ActiveRecord::Migration[7.2] | ||
def up | ||
Item.where(distribution_quantity: nil).find_each do |item| | ||
item.update_column(:distribution_quantity, item.kit_id.present? ? 1 : 50) | ||
end | ||
end | ||
|
||
def down | ||
raise ActiveRecord::IrreversibleMigration | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -434,6 +434,22 @@ | |
end | ||
end | ||
|
||
describe "when distribution_quantity is set by default" do | ||
it "should set distribution_quantity to 50 for regular items" do | ||
item = Item.new | ||
item.valid? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You shouldn't need to call this - your callback is |
||
expect(item.distribution_quantity).to eq(50) | ||
end | ||
|
||
it "should set distribution_quantity to 1 for kits" do | ||
organization = create(:organization) | ||
kit = create(:kit, organization: organization) | ||
item = Item.new(kit: kit) | ||
item.valid? | ||
expect(item.distribution_quantity).to eq(1) | ||
end | ||
end | ||
|
||
describe "distribution_quantity and package size" do | ||
it "have nil values if an empty string is passed" do | ||
expect(create(:item, distribution_quantity: '').distribution_quantity).to be_nil | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this if we have an
after_initialize
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it would be helpful for the user to see what the default was in the form. I just removed it and learned that we don't need it after all. Thank you for pointing this out.